-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks with requests 2.32.0: Not supported URL scheme http+docker #3256
Breaks with requests 2.32.0: Not supported URL scheme http+docker #3256
Comments
same problem
|
same! |
I'm currently debugging this a bit (ansible-collections/community.docker#860), the issue is commit psf/requests@c0813a2 in requests.
See for example https://github.com/docker/docker-py/blob/main/docker/transport/unixconn.py#L66. |
A simple fix is adding def _get_connection(self, request, *args, proxies=None, **kwargs):
return self.get_connection(request.url, proxies) at the bottom of https://github.com/docker/docker-py/blob/main/docker/transport/basehttpadapter.py. Not sure how sustainable that is, but it works for now :) |
Apparently requests==2.32.0 is incompatible with vendored versions of docker-py from inside community.docker collection. We do not have a direct dependency on that but one of our integration tests fails, so we only update our test dependencies. Related: docker/docker-py#3256 Related: ansible-collections/community.docker#860 Related: ansible-collections/community.docker#861
I created #3257 with that fix. |
) Signed-off-by: harupy <[email protected]>
same issue here, the fix from @felixfontein works for me! |
A temporary workaround for docker/docker-py#3256
Ditto here :) Just saw lots of builds start failing, glad there's already a fix... and it seems the CI build is failing already, but unrelated to the fix above. |
haha Seems a lot of CI fails cause this issue. me tooooooo. |
Our team wasted all day today trying to triage and put a fix to this problem. After this incident, is there any plan to revisit this unpinned dependency specification: Line 33 in b6464db
|
Pinning dependencies, in particular very general dependencies such as |
In our process, we had pinned to |
If you only pin direct dependencies, you're usually missing A LOT of indirect dependencies that can cause all kind of problems - such as in this case. You might want to use |
The latest version of docker-py fails on the latest version of requests See: docker/docker-py#3256 --------- Co-authored-by: Jay Chia <[email protected]@users.noreply.github.com>
* add 2.9 support * add v2.10 support * Add doc for maintenance calls * force requests==2.31.0 docker/docker-py#3256 * fix paperless_ngx_conf_trash_dir occurences * fix none type trash dir variable
To workaround issue docker/docker-py#3256
This version adds a bugfix for docker/docker-py#3256, which we experienced in our CI environment. Change-Id: I4e718d8a6464577b073c3e88157c47dc155a1e2d
…g dependencies installed We ran into this issue when trying to run kilosort through docker: docker/docker-py#3256 Hopefully updating docker-py to 7.1.0 fixes it: docker/docker-py#3257 (comment)
…g dependencies installed (#59) * Update spikeinterface and docker, add workflow to test with processing dependencies installed We ran into this issue when trying to run kilosort through docker: docker/docker-py#3256 Hopefully updating docker-py to 7.1.0 fixes it: docker/docker-py#3257 (comment) * Remove numba as an explicit dependency
requests==2.32.x affects docker-py docker/docker-py#3256
requests==2.32.x affects docker-py docker/docker-py#3256
I am using requests 2.32.3 and have the same issue! Is it fixed by now and is it released? |
The fix is included in docker-py 7.1.0. |
I faced the same problem. |
requests==2.32.x affects docker-py docker/docker-py#3256
requests==2.32.x affects docker-py docker/docker-py#3256
requests==2.32.x affects docker-py docker/docker-py#3256
With requests 2.32.0 (released about an hour ago as I write this), the docker library as called by tox-docker fails with the following exception:
Reverting to requests 2.31.0 without any other changes fixes the problem.
The text was updated successfully, but these errors were encountered: