Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ORM3 #2786

Closed
wants to merge 4 commits into from
Closed

Conversation

ajgarlag
Copy link

@ajgarlag ajgarlag commented Apr 4, 2024

Based on the incredible work of @oleg-andreyev on #2784, this PR adds support for ORM >= 3.0 keeping compatibility with ORM 2 and without removing Annotations or YAML support.

@mbabker
Copy link
Contributor

mbabker commented Apr 5, 2024

I need to rebuild the branch, but main...mbabker:DoctrineExtensions:orm-3-merge plus some version of #2768 should be pretty close to what all is needed (I know the MappedEventSubscriber.php change should go away for a final PR, but I've been working through that branch for so long I don't remember if I threw any other convenience hacks at it), minus factoring for some PHP 7.4 compat breaks (union types are used in ORM 3).

The custom ORM XML mapping driver should be 100% unnecessary, they reverted the hard mapping requirements for that driver because of the inability to use a custom XSD making extensions with XML config impossible (follow doctrine/orm#11123 for that, and the MongoDB ODM folks have an eye on that too since they have a similar issue with their XML mapping).

@Seb33300
Copy link

Seb33300 commented Jun 9, 2024

I am using that branch in my project and it's working so far. (but I only use Blameable & Timestampable)
The only point I noticed is that compatibility with DBAL 4 is missing.

It could be nice to start merging PR related to ORM3 even if they're not 100% completed.
This will make it easy for everybody to start testing and report broken features.
For instance by creating a BETA version release.

@franmomu
Copy link
Collaborator

main branch is now compatible with ORM 2 and 3 with the changes @mbabker pointed out, if would be nice if people give it a try before making a release, thanks @ajgarlag for the work you did here

@franmomu franmomu closed this Jun 10, 2024
@Seb33300
Copy link

I will update my project to dev-master and let you know if I face any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants