-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DB name passing in SqliteSchemaManager::listTableForeignKeys() #6338
Conversation
Is this explanation enough or do you want to a functional test with |
@derrabus may I understand your wishes better? |
I will always ask for tests. Just don't open PRs without tests and ask if you should write a test. Write the test. Thanks. |
59e6d96
to
2797e73
Compare
Is there anything with the CI? SQLite tests and CS/stan tests were passing, I have then rebased the PR on the latest 3.8.x, but now stan/SQLite testing is failing. How to fix it? |
I've started a new CI run after your comment and it passed. So no, the CI looks fine to me. |
2797e73
to
7c0346b
Compare
7c0346b
to
95516ba
Compare
Repushed and all tests are passing. Let me know if there is anything else to address. |
@derrabus can I please have your review? |
Thank you. |
* 4.1.x: Fix example for QB delete and update in doc block Bump doctrine/.github from 5.0.0 to 5.0.1 (#6391) PHPStan 1.10.67, PHPUnit 9.6.19, PHPCS 3.9.2 (#6387) Fix "Plugin 'mysql_native_password' is not loaded" (#6388) Run tests against MySQL 8.4 (#6386) Use 3.8.x as a target for dependabot version updates (#6384) Setup dependabot Fix SQLiteSchemaManagerTest case Switch to substr implementation fix merge Bump workflow actions Fix SQL Server "extended property" SQL generation (#6353) Fix DB name passing in SqliteSchemaManager::listTableForeignKeys() (#6338) Fix SQLite temp table name must not contain dot (#6315) Provide CODECOV_TOKEN Upgrade to codecov/codecov-action v4 Set fail_ci_if_error flag to true Specify the minor version number
Summary
Fix #5617,
''
was changed to'main'
, but one occurence was missed.