Set fail_ci_if_error flag to true

[greg0ire]

In a recent PR, we got reports from CodeCov about several lines not being covered. After further inspection, I found an error message in the coverage file upload saying we hit a rate limit.
This will make it more likely we spot such issues in the future.

[greg0ire]

I expect the first build here to be red, and after that I will follow the instructions at https://docs.codecov.com/docs/adding-the-codecov-token and then it should be green 🤞

[greg0ire]

Finally! A build that fails because of Codecov

[greg0ire]

Ah but secrets are just not passed to workflows triggered from a fork, so there is no way this is going to work, is there? 😞

[greg0ire]

Looks like v4 addresses this ?

[greg0ire]

86.54% (+19.54%) compared to b05e48a

Wonderful increase 😁

Looking at the CodeCov UI, it says there is only 1 upload, but when I download it, I can see it contains several reports.

Note that we might have to specify CODECOV_TOKEN for builds not emanating from a fork. Let's see what happens after merging this? If there is an issue, I will make another PR, this time from a branch I would push directly to this repository.

[SenseException]

I'd expect that error to appear again. Should codecov upload on a PR? What about having just a coverage % output on a PR and the upload on merges to the branches? Food for thoughts if another PR is needed.

[greg0ire]

Should codecov upload on a PR?

IMO it can be useful for us to see what part of a patch is uncovered before merging, so yes. If the error appears again, that won't prevent a merge, and it's IMO better for us to be aware of the issue rather than getting lots of comments about lines being uncovered.