Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more uncountable words to Uninflected.php #216

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Add more uncountable words to Uninflected.php #216

merged 2 commits into from
Jan 26, 2023

Conversation

judaschwartz
Copy link
Contributor

A more complete list of uncountable words
source https://grammarist.com/grammar/uncountable-nouns/

@judaschwartz
Update Uninflected.php
a002144 
A more complete list of uncountable words
source https://grammarist.com/grammar/uncountable-nouns/
@judaschwartz
Copy link
Contributor Author

Looks like theres a problem with the Continuous Integration / Roave BC Check (pull_request) test

@greg0ire
Copy link
Member

Yes, you can ignore it, we're aware and are awaiting a resolution from upstream.

@greg0ire greg0ire added this to the 2.0.7 milestone Jan 26, 2023
@greg0ire greg0ire merged commit d3608f3 into doctrine:2.0.x Jan 26, 2023
@greg0ire
Copy link
Member

Thanks @judaschwartz !

@judaschwartz judaschwartz deleted the patch-5 branch January 26, 2023 13:45
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
Merged
driesvints
driesvints reviewed Jun 16, 2023
View reviewed changes
lib/Doctrine/Inflector/Rules/English/Uninflected.php
yield new Pattern('engineering');
yield new Pattern('entertainment');
yield new Pattern('enthusiasm');
yield new Pattern('environment');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@judaschwartz @greg0ire hi there. This broke Laravel's test suite. environment is definitely a countable word: https://en.wiktionary.org/wiki/environment

Screenshot 2023-06-16 at 14 17 06

Can we please revert this and tag a patch release? Right now, all of our PR's are failing. Thanks!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sent in a PR for this: #222

@driesvints driesvints mentioned this pull request Jun 16, 2023
Closed
@limenet limenet mentioned this pull request Jun 16, 2023
Open
greg0ire added a commit to greg0ire/inflector that referenced this pull request Jun 16, 2023
@greg0ire
Revert "Merge pull request doctrine#216 from judaschwartz/patch-5"
339993a 
This reverts commit d3608f3, reversing
changes made to ebd91a0.
greg0ire added a commit to greg0ire/inflector that referenced this pull request Jun 16, 2023
@greg0ire
Revert "Merge pull request doctrine#216 from judaschwartz/patch-5"
b8ea17c 
This reverts commit d3608f3, reversing
changes made to ebd91a0.

As it turns out, many of these changes were dubious, such as
"permission" or "environment".

Also, we need to decide if this is a breaking change or not.
In the meantime, let us revert this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints left review comments

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@judaschwartz @greg0ire @driesvints @SenseException