Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pki-server <subsystem>-user-cert-del #4428

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Apr 28, 2023

The pki-server <subsystem>-user-cert-del command has been added to remove a cert from the user record such that the cert cannot be used for authentication.

A new test has been added to validate removing and restoring the admin cert.

https://github.com/dogtagpki/pki/wiki/PKI-Server-Subsystem-User-Certificate-CLI

@edewata edewata requested a review from fmarco76 April 28, 2023 02:53
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are a couple of code smells which can be addressed but feel free to merge as it is.

The pki-server <subsystem>-user-cert-del command has been added
to remove a cert from the user record such that the cert cannot
be used for authentication.
A new test has been added to validate removing and restoring the
admin cert.
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
7.0% 7.0% Duplication

@edewata
Copy link
Contributor Author

edewata commented Apr 28, 2023

@fmarco76 The code smells are gone now. Thanks!

@edewata edewata merged commit 154b694 into dogtagpki:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants