Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OAEP config in CRSEnrollment #4430

Merged
merged 2 commits into from
May 3, 2023
Merged

Fix OAEP config in CRSEnrollment #4430

merged 2 commits into from
May 3, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented May 2, 2023

The EngineConfig.getUseOAEPKeyWrap() has been added to read the keyWrap.useOAEP param from CS.cfg. All code that reads this param has been modified to use this method.

Previously the CRSEnrollment was trying to get the keyWrap.useOAEP param from the authority config, but it's actually reading a non-existent ca.keyWrap.useOAEP param.

To fix the problem the code has been modified to call the EngineConfig.getUseOAEPKeyWrap() as well.

@edewata edewata requested a review from jmagne May 2, 2023 18:29
The EngineConfig.getUseOAEPKeyWrap() has been added to read
the keyWrap.useOAEP param from CS.cfg. All code that reads this
param has been modified to use this method.
Previously the CRSEnrollment was trying to get the
keyWrap.useOAEP param from the authority config, but it's
actually reading a non-existent ca.keyWrap.useOAEP param.

To fix the problem the code has been modified to call the
EngineConfig.getUseOAEPKeyWrap().
@edewata edewata changed the title Fix OAEP config in CRSEnrollment.init() Fix OAEP config in CRSEnrollment May 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
11.1% 11.1% Duplication

Copy link
Contributor

@jmagne jmagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good clarify improvement and solves the original issue as well, approving.

@edewata
Copy link
Contributor Author

edewata commented May 3, 2023

@jmagne Thanks!

@edewata edewata merged commit 955856b into dogtagpki:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants