Add server-webapp module #4431
Merged
Add server-webapp module #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PKIApplication class and the services in it are supposed to be deployed under /pki webapp only, but currently these classes are included in pki-server.jar so they are also distributed in all other webapps although they are not actually used there. In Servlet 3.0 framework all application classes in the webapp will be initialized automatically, so the current packaging could become a problem. To avoid the problem the files for /pki webapp need to be moved into a new server-webapp module, and the PKIApplication with the services in it need to be moved into pki-server-webapp.jar which will only be deployed under /pki webapp.
|
Kudos, SonarCloud Quality Gate passed!
|
fmarco76
approved these changes
May 3, 2023
|
@ckelleyRH @fmarco76 Thanks! I was thinking we might eventually have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PKIApplicationclass and the services in it are supposed to be deployed under/pkiwebapp only, but currently these classes are included inpki-server.jarso they are also distributed in all other webapps although they are not actually used there.In Servlet 3.0 framework all application classes in the webapp will be initialized automatically, so the current packaging could become a problem.
To avoid the problem the files for
/pkiwebapp need to be moved into a newserver-webappmodule, and thePKIApplicationwith the services in it need to be moved intopki-server-webapp.jarwhich will only be deployed under/pkiwebapp.