Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate algorithm in OCSPAdminServlet.getSigningAlgConfig() #4433

Merged
merged 1 commit into from
May 5, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented May 4, 2023

Previously the OCSPAdminServlet.getSigningAlgConfig() returned a list that contained a duplicate of the first element:

<alg1><alg1>:<alg2>:<alg3>:...

The code has been modified to remove the duplicate.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2193458

@edewata edewata requested a review from ladycfu May 4, 2023 19:06
Previously the OCSPAdminServlet.getSigningAlgConfig() returned
a list that contained a duplicate of the first element:

  <alg1><alg1>:<alg2>:<alg3>:...

The code has been modified to remove the duplicate.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2193458
Copy link
Contributor

@ladycfu ladycfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented May 5, 2023

@ladycfu Thanks!

@edewata edewata merged commit c9f4820 into dogtagpki:master May 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants