Remove AIA extension from root CA signing cert #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bootstrap caCert.profile has been modified such that root CA signing certs will no longer have an AIA extension. The regular CA signing cert profiles have not been modified so sub CA signing certs will continue to have an AIA extension.
Some CI tests have been updated to validate the AIA extension removal from root CA signing certs. The test-ca-signing-cert-ext.sh has been modified to verify that there's no AIA extensions in root CA signing cert. The test-subca-signing-cert-ext.sh has been modified to check for an AIA extension in sub CA signing cert pointing to the root CA's OCSP responder. A new test-ms-subca-signing-cert-ext.sh has been added as a copy of the original test-subca-signing-cert-ext.sh to check for MS sub CA extensions.
|
Kudos, SonarCloud Quality Gate passed!
|
ladycfu
reviewed
May 9, 2023
| sed -En '1N;$!N;s/^ *(1.3.6.1.4.1.311.20.2: .*)\n *(.*)\n *(.*)/\1\n\2\n\3/p;D' output | tee actual | ||
| # verify there is an AIA extension pointing to root CA's OCSP responsder | ||
| echo "Authority Information Access: " > expected | ||
| echo "OCSP - URI:http://root.example.com:8080/ca/ocsp" >> expected |
There was a problem hiding this comment.
ok here. Just want to point out that if the root CA has an external OCSP setup, and its ca.defaultOcspUri (in CS.cfg) is set to point to the external OCSP then all the certs signed by the ca will have AIA pointing to the value of ca.defaultOcspUri.
There was a problem hiding this comment.
yeah, we don't have any tests for ca.defaultOcspUri in upstream CI right now.
|
@ladycfu Thanks! I'll merge this to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bootstrap
caCert.profilehas been modified such that root CA signing certs will no longer have an AIA extension. The regular CA signing cert profiles have not been modified so sub CA signing certs will continue to have an AIA extension.Some CI tests have been updated to validate the AIA extension removal from root CA signing certs.
The
test-ca-signing-cert-ext.shhas been modified to verify that there's no AIA extensions in root CA signing cert.The
test-subca-signing-cert-ext.shhas been modified to check for an AIA extension in sub CA signing cert pointing to the root CA's OCSP responder.A new
test-ms-subca-signing-cert-ext.shhas been added as a copy of the originaltest-subca-signing-cert-ext.shto check for MS sub CA extensions.Test results:
Notes:
caCert.profilemay need to be cherry-picked intov10.13branch.