Code clean up in Job #4462
Merged
Code clean up in Job #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make logger final * Reduce visibility of public constructor * Use built in logger formatting * Remove unnecessary override of run() * Remove unnecessary Boolean literal * Combine identical catch clauses * Rearrange logic in build methods for readability A separate change will replace the synchronized HashTable instances
|
Kudos, SonarCloud Quality Gate passed! |
edewata
approved these changes
Jun 2, 2023
| @@ -110,6 +109,7 @@ public boolean isEnabled() { | |||
| try { | |||
| enabled = mConfig.isEnabled(); | |||
| } catch (EBaseException e) { | |||
| // Swallow exceptions? | |||
There was a problem hiding this comment.
Ideally we should not do this, but this is happening all over the place. Feel free to fix it whenever you see it, but just beware that it might change the behavior of the code.
There was a problem hiding this comment.
Yeah I try not to alter the control/exception flow when I am wearing my janitor uniform, but I often document that I have not touched things as I go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A separate change will replace the synchronized HashTable instances