Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean up in CertRecordProcessor #4470

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

ckelleyRH
Copy link
Contributor

  • Make logger final
  • Remove unnecessary Boolean literals
  • Invert negated if statements for readability
  • Use built in logger formatting
  • Rename onlySomeReasons to not hide the field
  • Replace synchronized HashTable and Vector instances (Vector/HashTable are technically still used as they are
    the implementations of List/Map passed in by at least some of the calling code)

* Make logger final
* Remove unnecessary Boolean literals
* Invert negated if statements for readability
* Use built in logger formatting
* Rename onlySomeReasons to not hide the field
* Replace synchronized HashTable and Vector instances (Vector/HashTable
are technically still used as they are
the implementations of List/Map passed in by at least some of the
calling code)
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
3.0% 3.0% Duplication

@ckelleyRH ckelleyRH merged commit 9614f95 into dogtagpki:master Jun 12, 2023
134 checks passed
@ckelleyRH
Copy link
Contributor Author

Thanks @fmarco76 !

@ckelleyRH ckelleyRH deleted the CertRecordProcessor branch June 12, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants