Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move REST endpoint to v1 #4771

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Conversation

fmarco76
Copy link
Member

@fmarco76 fmarco76 commented Jun 6, 2024

The current REST implemenation is associated to /v1 path and the /rest path is a redirect to the /v1.

This would make easier to switch between REST implementations.

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment, but it LGTM.

@@ -32,7 +34,7 @@
<security-constraint>
<web-resource-collection>
<web-resource-name>Agent Services</web-resource-name>
<url-pattern>/rest/agent/*</url-pattern>
<url-pattern>/v1/agent/*</url-pattern>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep the old URL?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep the old URL?

You are right, it is not needed. Removed!

The current REST implemenation is associated to /v1 path and the /rest
path is a redirect to the /v1.

This would make easier to switch between REST implementations.
The current rest APIs are moved to a subpackage named `v1`. The new
implementation has moved to the subpackage `v1`. The new implementation
has moved to the subpackage `v2`. This will simplify the selective
building of REST implementation.

Subsystems ACME and EST have not been modified because they use REST to
implement the protocol and this requires extra effort.
@fmarco76 fmarco76 marked this pull request as ready for review June 7, 2024 09:36
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16 Security Hotspots

See analysis details on SonarCloud

@fmarco76
Copy link
Member Author

fmarco76 commented Jun 7, 2024

@edewata Thanks! I have updated the path for the classes.
The sonar test is failing from some code in v1 REST APIs I have not modified but moving the files they get re-evaluated.
I am ignoring it in this PR.

@fmarco76 fmarco76 merged commit e5b208a into dogtagpki:master Jun 7, 2024
145 of 152 checks passed
@fmarco76 fmarco76 deleted the APIversionSelection branch June 7, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants