Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant files in containers #4772

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jun 7, 2024

The containers have been updated to remove redundant files to avoid conflicting or obsolete certs.

When the container is started the certs provided in /certs will be the authoritative data and will be imported into the server and admin NSS databases. If the certs are not provided, the container will generate new certs directly in the NSS databases. Once the container is running, the certs in the NSS databases will be the authoritative data until the container is restarted.

So now the container will only store certs and keys in NSS databases and CSR files, but it will no longer store cert files or PKCS #12 files since they are redundant. The tests have been updated to export these files from the container when they are needed.

The containers have been updated to remove redundant files
to avoid conflicting or obsolete certs.

When the container is started the certs provided in /certs
will be the authoritative data and will be imported into
the server and admin NSS databases. If the certs are not
provided, the container will generate new certs directly in
the NSS databases. Once the container is running, the certs
in the NSS databases will be the authoritative data until
the container is restarted.

So now the container will only store certs and keys in NSS
databases and CSR files, but it will no longer store cert
files or PKCS dogtagpki#12 files since they are redundant. The tests
have been updated to export these files from the container
when they are needed.
Copy link

sonarcloud bot commented Jun 7, 2024

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Jun 10, 2024

@fmarco76 Thanks!

@edewata edewata merged commit e4a9fb0 into dogtagpki:master Jun 10, 2024
146 of 152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants