Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v2 TPS TokenService without vlv #4779

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

fmarco76
Copy link
Member

The TokenService has been implemented using raw servlet. Since this service is using different http methods and acl for the supported methods, the base PKIServlet has been modified to support such methods. Additionally, ACL uses the new map definition to control each method.

The TokenService has been implemented using raw servlet. Since this
service is using different http methods and acl for the supported
methods, the base PKIServlet has been modified to support such methods.
Additionally, ACL uses the new map definition to control each method.
@fmarco76
Copy link
Member Author

I have verified all the v2 endpoints with curl and they work as the equivalent v1 endpoints.

@fmarco76 fmarco76 requested a review from edewata June 13, 2024 14:04
Copy link

sonarcloud bot commented Jun 13, 2024

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The new code seems to be consistent with the original code.

@fmarco76
Copy link
Member Author

@edewata Thanks!

@fmarco76 fmarco76 merged commit 3e99af1 into dogtagpki:master Jun 14, 2024
148 of 153 checks passed
@fmarco76 fmarco76 deleted the TokenServiceFreeVLV branch June 14, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants