Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for CA container user service #4780

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jun 14, 2024

A new test has been added to run a CA container as a rootless systemd service in user space then perform a cert enrollment.

https://github.com/dogtagpki/pki/wiki/Deploying-CA-Container-as-Systemd-Service

@edewata edewata requested a review from fmarco76 June 14, 2024 21:15
@edewata
Copy link
Contributor Author

edewata commented Jun 14, 2024

@fmarco76 Here the login shell needs to be enabled before we can use pkiuser for systemd user service. Should we enable it by default in the RPM spec so pkiuser will work like a regular user, or do we want the sysadmin to enable it manually (and possibly enable the home directory manually too)? A normal user usually will have the login shell and home directory enabled by default.

@ladycfu @jmagne Do you have any opinion about this?

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmarco76
Copy link
Member

@fmarco76 Here the login shell needs to be enabled before we can use pkiuser for systemd user service. Should we enable it by default in the RPM spec so pkiuser will work like a regular user, or do we want the sysadmin to enable it manually (and possibly enable the home directory manually too)? A normal user usually will have the login shell and home directory enabled by default.

Will these steps be manually performed or there is a plan to deploy containers with pkispawn (or a new command)? If a tool will be used then we could add the home and shell configuration on such a tool otherwise I would leave to sysadmin for the moment, at least until we have finalised all the container setup.

A new test has been added to run a CA container as a rootless
systemd service in user space then perform a cert enrollment.
@edewata
Copy link
Contributor Author

edewata commented Jun 18, 2024

@fmarco76 Thanks! Yeah, we probably can add some options in pkispawn to deploy PKI as a container instead of in regular Tomcat instance, and the tool will do the required steps. We'll do that in another PR.

Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@edewata edewata merged commit 311d7b4 into dogtagpki:master Jun 18, 2024
147 of 154 checks passed
@edewata
Copy link
Contributor Author

edewata commented Jun 19, 2024

One thing though, suppose we want to run PKI server as pkiuser and use the home directory to store SoftHSM token or other things, the home directory needs to be created manually before running pkispawn. Adding a home directory is not difficult, but most people probably would need to look up the docs or find examples, so it's not that user-friendly.

@fmarco76
Copy link
Member

Not sure on this scenario at the moment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants