Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing race condition on close connection #4789

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

fmarco76
Copy link
Member

LDAPConnection is closed before it is re-used. Closing the connection in case it is not needed create a race conditions in some cases preventing the execution. This is present in IPA cloning operations.

LDAPConnection is closed before it is re-used. Closing the connection in
case it is not needed create a race conditions in some cases preventing
the execution. This is present in IPA cloning operations.
@fmarco76 fmarco76 requested a review from edewata June 24, 2024 12:48
@fmarco76
Copy link
Member Author

@edewata The IPA clone CI is still failing but now it fails in a different step. KRA gets installed in the clone.
I am investigating the remaining issues in IPA CI.

This could fix the #4773 but we need tests from their CI.

Copy link

sonarcloud bot commented Jun 24, 2024

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Yeah, generally if the code doesn't create the connection it shouldn't close it either.

@fmarco76
Copy link
Member Author

@edewata Thanks!

@fmarco76 fmarco76 merged commit 782f3ab into dogtagpki:master Jun 24, 2024
150 of 156 checks passed
@fmarco76 fmarco76 deleted the KRACloneIPAFailing branch June 24, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants