Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Hash and Eq for ResolvedNode and ResolvedToken. #63

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

aDotInTheVoid
Copy link
Contributor

These simply forward to the impls for SyntaxNode and SyntaxToken respectivly.

@domenicquirl
Copy link
Owner

Hey, thanks for sending a PR! This seems fine to add, so I'm happy to merge this :)

Just as a heads-up though, it might take a bit until this actually goes in and ends up in a release since I'm currently trying to figure out what to do about Kixiron/lasso#47 :/

@aDotInTheVoid
Copy link
Contributor Author

totally understood. i don’t need it urgently at all, as im currently accessing it via git, and i don’t intend to publish to crates.io

@domenicquirl
Copy link
Owner

Alright, thanks for your patience @aDotInTheVoid! There's a new release of lasso, which means that everything runs again 🥳

It seems like GitHub no longer lets me approve CI if I haven't done so within 30 days (which imo is an odd decision, given that I can still merge the PR without CI) - would you mind rebasing onto master? I did a quick dependency and clippy update, so CI should be happy once we get to run it ☺️

@domenicquirl
Copy link
Owner

Also, feel free to add a line in the changelog about this change. If you do, you'll probably need to add an "Unreleased" Section since the changelog only starts with version 0.12.

You don't have to do this though, we can also land the PR just with the rebase and I'll add something when I merge and prep a release.

These simply forward to the impls for SyntaxNode and SyntaxToken respectivly.
@aDotInTheVoid
Copy link
Contributor Author

Pushed a rebased version with a changelog entry.

@domenicquirl domenicquirl merged commit 1080120 into domenicquirl:master Aug 21, 2024
23 checks passed
@aDotInTheVoid aDotInTheVoid deleted the resolved-impls branch August 21, 2024 15:55
@domenicquirl
Copy link
Owner

Thanks again for following up, and for making the contribution in the first place. This change has now been released with cstree version 0.12.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants