Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a strategy to discard redundant sampling at later stages of the app's lifecycle #10

Merged

Conversation

john-y-pazekha
Copy link
Contributor

@john-y-pazekha john-y-pazekha commented Jul 2, 2020

Fixing issue #9 on Android

The existing behavior is 100% preserved. Clients who want to enforce the single-sampling strategy should use new constructor with parameter true:

packages = asList(...
    new RNStartupTimePackage(true),
    ...);

Those clients who use old constructor shall enjoy the old behaviour without changes.

@doomsower
Copy link
Owner

Thank you for your contribution! Could you please add a few lines about this feature to readme?

@john-y-pazekha
Copy link
Contributor Author

Thanks for a good point!
Done!

@doomsower doomsower merged commit 65f6d30 into doomsower:master Jul 3, 2020
doomsower pushed a commit that referenced this pull request Jul 3, 2020
# [1.3.0](v1.2.2...v1.3.0) (2020-07-03)

### Features

* redundant invocations on Android ([65f6d30](65f6d30)), closes [#10](#10)
@doomsower
Copy link
Owner

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@onlyanegg
Copy link

Hi! I'm wondering if there's a way to control this behavior from JS-land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants