Skip to content

Commit

Permalink
Address PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
stephentoub committed Mar 25, 2021
1 parent f046730 commit b514596
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ internal class Http2OutputProducer : IHttpOutputProducer, IHttpOutputAborter, IV
private bool _writerComplete;

// Internal for testing
internal ValueTask _dataWriteProcessingTask;
internal Task _dataWriteProcessingTask;
internal bool _disposed;

/// <summary>The core logic for the IValueTaskSource implementation.</summary>
Expand Down Expand Up @@ -74,7 +74,7 @@ public Http2OutputProducer(Http2Stream stream, Http2StreamContext context, Strea
// The minimum output data rate is enforced at the connection level by Http2FrameWriter.
_flusher = new TimingPipeFlusher(_pipeWriter, timeoutControl: null, _log);

_dataWriteProcessingTask = ProcessDataWrites().Preserve();
_dataWriteProcessingTask = ProcessDataWrites();
}

public void StreamReset()
Expand Down Expand Up @@ -394,7 +394,7 @@ public void Reset()
{
}

private async ValueTask ProcessDataWrites()
private async Task ProcessDataWrites()
{
// ProcessDataWrites runs for the lifetime of the Http2OutputProducer, and is designed to be reused by multiple streams.
// When Http2OutputProducer is no longer used (e.g. a stream is aborted and will no longer be used, or the connection is closed)
Expand Down

0 comments on commit b514596

Please sign in to comment.