Add GC committed bytes to known counters #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyosjs
approved these changes
Apr 2, 2021
davmason
approved these changes
Apr 2, 2021
|
Can we make this counter MB instead of B to align with the heap size counter? |
|
@davidfowl we could, but in general the GC counters are a little all over the place (some are in MB, some are in B). It might make more sense to make everything in B. |
|
For things we already shipped in .NET 5 I don't think we should change them or it could break people's monitoring rules. Things added during .NET 6 we can still change and we should try to be more consistent going forward. |
|
Lets make it MB then its weird seeing 19MB for GC heap and 45,000,000 B for committed GC bytes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding runtime PR: dotnet/runtime#50604