Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PVP flow for sourcelink #15632

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Revert PVP flow for sourcelink #15632

merged 1 commit into from
Feb 27, 2023

Conversation

mthalman
Copy link
Member

This reverts the portion of commit ee2f220 from #15437 that enabled PVP flow for sourcelink. This is because it causes prebuilts to be introduced for the following assemblies: System.Text.Json and System.Reflection.Metadata.

Once dotnet/sourcelink#964 is fixed, then this change can be added back, allowing PVP flow for sourcelink.

@MichaelSimons
Copy link
Member

cc @mmitche

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be ported to the preview2 branch.

@mthalman mthalman merged commit 58164d0 into dotnet:main Feb 27, 2023
@mthalman mthalman deleted the revert branch February 27, 2023 15:52
mthalman added a commit to mthalman/installer that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants