[dualscreen] project/nuget for Surface Duo and other Android foldables #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dual screen foldable initial commit
Other > Dual Screen
based on changes in dotnet#3213 where APIs moved to Essentials
untested
merge main into foldable
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
approved these changes
Apr 5, 2022
mattleibow
added a commit
that referenced
this pull request
Apr 7, 2022
Temporary removing the two pane page from the sample from #5020. Something is causing the build to fail with GENERATEPROJECTPRIFILE : error : PRI175: 0x80073b0f - Processing Resources failed with error: Duplicate Entry.
mattleibow
added a commit
that referenced
this pull request
Apr 7, 2022
Temporary removing the two pane page from the sample from #5020. Something is causing the build to fail with GENERATEPROJECTPRIFILE : error : PRI175: 0x80073b0f - Processing Resources failed with error: Duplicate Entry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Provides .NET MAUI support for Android dual-screen and foldable devices (eg. Surface Duo, Galaxy Fold). Builds upon the APIs previously available in Xamarin.Forms. The underlying support for hinge detection and angle should be a no-op on non-Android devices, but TwoPaneView will still work with configurable/proportional layout.
Microsoft.Maui.Controls.Foldable.TwoPaneViewcontrolMicrosoft.Maui.Foldable.DualScreenInfoclassInitcall with.UseFoldable()host builder extension.UseFoldable()inMaui.Controls.Sample.MauiProgram(Startup.cs)Issues Fixed
Fixes #1752 Make DualScreen controls work in MAUI
Fixes #1753 Update DualScreen controls to use new Jetpack Window Manager on Android
Notes
A few outstanding inconsistencies currently being addressed:
Questions
DualScreenInfotoFoldableInfo? Feels like a low impact change either way and without a strong reason to change it, easier to leave as-is and keep the 'backwards compat' associated with the original name...cc @PureWeen