Merge branch 'master' into CA1806-user-option

RoslynAnalyzers.sln

@@ -128,10 +128,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Metrics.Legacy", "src\Tools
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Metrics.Package", "nuget\Microsoft.CodeAnalysis.Metrics\Microsoft.CodeAnalysis.Metrics.Package.csproj", "{C96D2F95-3090-4376-942C-2C934C55283B}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "GenerateAnalyzerRulesets", "GenerateAnalyzerRulesets", "{1B75E62D-E35D-4FF0-B5A4-78D60D3A3388}"
-EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GenerateAnalyzerRulesets", "src\Tools\GenerateAnalyzerRulesets\GenerateAnalyzerRulesets.csproj", "{3727E79D-8250-492E-8082-9A5D0C0AD0D9}"
-EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "ReleaseNotesUtil", "ReleaseNotesUtil", "{6AAE1FC7-D96E-40CB-8B52-EA87EF9BF00A}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ReleaseNotesUtil", "src\Tools\ReleaseNotesUtil\ReleaseNotesUtil.csproj", "{01518AF6-AE8F-4ADA-ABE4-C78F8234899F}"
@@ -166,6 +162,10 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "GenerateGlobalAnalyzerConfi
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GenerateGlobalAnalyzerConfigs", "src\Tools\GenerateGlobalAnalyzerConfigs\GenerateGlobalAnalyzerConfigs.csproj", "{3DD9D249-13D4-4DD2-B043-1F025F550013}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "GenerateDocumentationAndConfigFiles", "GenerateDocumentationAndConfigFiles", "{DB2DD702-8301-4FC6-B8C0-029C7DCC2931}"
+EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GenerateDocumentationAndConfigFiles", "src\Tools\GenerateDocumentationAndConfigFiles\GenerateDocumentationAndConfigFiles.csproj", "{563654BA-4C05-4EA2-91D3-28A14723B7D5}"
+EndProject
 Global
 	GlobalSection(SharedMSBuildProjectFiles) = preSolution
 		src\Utilities\Compiler\Analyzer.Utilities.projitems*{0a0621f2-d1dc-47ff-b643-c6646557505e}*SharedItemsImports = 5
@@ -177,8 +177,8 @@ Global
 		src\Utilities\Compiler\Analyzer.Utilities.projitems*{2a4af3a4-307b-4252-888e-e6546244585a}*SharedItemsImports = 5
 		src\Utilities\Workspaces\Workspaces.Utilities.projitems*{2a4af3a4-307b-4252-888e-e6546244585a}*SharedItemsImports = 5
 		src\Utilities\Compiler\Analyzer.Utilities.projitems*{2a520f3e-8c5d-43fe-aa03-fe5e3c5f23d1}*SharedItemsImports = 5
-		src\Utilities\Compiler\Analyzer.Utilities.projitems*{3727e79d-8250-492e-8082-9a5d0c0ad0d9}*SharedItemsImports = 5
 		src\Utilities\Compiler\Analyzer.Utilities.projitems*{3dd9d249-13d4-4dd2-b043-1f025f550013}*SharedItemsImports = 5
+		src\Utilities\Compiler\Analyzer.Utilities.projitems*{563654ba-4c05-4ea2-91d3-28a14723b7d5}*SharedItemsImports = 5
 		src\Utilities\Compiler\Analyzer.Utilities.projitems*{730c2d1c-0276-4132-85ea-675ce60068bb}*SharedItemsImports = 5
 		src\Utilities\Workspaces\Workspaces.Utilities.projitems*{730c2d1c-0276-4132-85ea-675ce60068bb}*SharedItemsImports = 5
 		src\Utilities\Workspaces\Workspaces.Utilities.projitems*{99f594b1-3916-471d-a761-a6731fc50e9a}*SharedItemsImports = 13
@@ -377,10 +377,6 @@ Global
 		{C96D2F95-3090-4376-942C-2C934C55283B}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{C96D2F95-3090-4376-942C-2C934C55283B}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{C96D2F95-3090-4376-942C-2C934C55283B}.Release|Any CPU.Build.0 = Release|Any CPU
-		{3727E79D-8250-492E-8082-9A5D0C0AD0D9}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{3727E79D-8250-492E-8082-9A5D0C0AD0D9}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{3727E79D-8250-492E-8082-9A5D0C0AD0D9}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{3727E79D-8250-492E-8082-9A5D0C0AD0D9}.Release|Any CPU.Build.0 = Release|Any CPU
 		{01518AF6-AE8F-4ADA-ABE4-C78F8234899F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
 		{01518AF6-AE8F-4ADA-ABE4-C78F8234899F}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{01518AF6-AE8F-4ADA-ABE4-C78F8234899F}.Release|Any CPU.ActiveCfg = Release|Any CPU
@@ -433,6 +429,10 @@ Global
 		{3DD9D249-13D4-4DD2-B043-1F025F550013}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{3DD9D249-13D4-4DD2-B043-1F025F550013}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{3DD9D249-13D4-4DD2-B043-1F025F550013}.Release|Any CPU.Build.0 = Release|Any CPU
+		{563654BA-4C05-4EA2-91D3-28A14723B7D5}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{563654BA-4C05-4EA2-91D3-28A14723B7D5}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{563654BA-4C05-4EA2-91D3-28A14723B7D5}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{563654BA-4C05-4EA2-91D3-28A14723B7D5}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -486,8 +486,6 @@ Global
 		{CADE5623-CC57-43A2-9D2A-B7AB29225406} = {50FB229D-38DB-4A34-8588-D33671AB68DE}
 		{2A4AF3A4-307B-4252-888E-E6546244585A} = {50FB229D-38DB-4A34-8588-D33671AB68DE}
 		{C96D2F95-3090-4376-942C-2C934C55283B} = {50FB229D-38DB-4A34-8588-D33671AB68DE}
-		{1B75E62D-E35D-4FF0-B5A4-78D60D3A3388} = {C0B86774-8307-444F-9EE4-98D62C3424F9}
-		{3727E79D-8250-492E-8082-9A5D0C0AD0D9} = {1B75E62D-E35D-4FF0-B5A4-78D60D3A3388}
 		{6AAE1FC7-D96E-40CB-8B52-EA87EF9BF00A} = {C0B86774-8307-444F-9EE4-98D62C3424F9}
 		{01518AF6-AE8F-4ADA-ABE4-C78F8234899F} = {6AAE1FC7-D96E-40CB-8B52-EA87EF9BF00A}
 		{1C62A2F6-7A44-4030-9D1A-7E7A966736E5} = {31F86414-C34B-462A-AFB5-BDA7724904F3}
@@ -504,6 +502,8 @@ Global
 		{64D70469-18B0-446C-80E9-A7C45A747B3E} = {02F88961-A08F-451A-93AB-328792A32EBC}
 		{0194F644-14D0-4AF4-8FA1-5CEA07DC7F5F} = {C0B86774-8307-444F-9EE4-98D62C3424F9}
 		{3DD9D249-13D4-4DD2-B043-1F025F550013} = {0194F644-14D0-4AF4-8FA1-5CEA07DC7F5F}
+		{DB2DD702-8301-4FC6-B8C0-029C7DCC2931} = {C0B86774-8307-444F-9EE4-98D62C3424F9}
+		{563654BA-4C05-4EA2-91D3-28A14723B7D5} = {DB2DD702-8301-4FC6-B8C0-029C7DCC2931}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {FC44ACA9-AEA3-4EE6-881C-2E08ED281B5F}

eng/GenerateAnalyzerNuspec.csx

@@ -222,11 +222,12 @@ if (editorconfigsDir.Length > 0 && Directory.Exists(editorconfigsDir))
 
 if (globalAnalyzerConfigsDir.Length > 0 && Directory.Exists(globalAnalyzerConfigsDir))
 {
-    foreach (string editorconfig in Directory.EnumerateFiles(globalAnalyzerConfigsDir))
+    foreach (string directory in Directory.EnumerateDirectories(globalAnalyzerConfigsDir))
     {
-        if (Path.GetExtension(editorconfig) == ".editorconfig")
+        var directoryName = new DirectoryInfo(directory).Name;
+        foreach (string editorconfig in Directory.EnumerateFiles(directory))
         {
-            result.AppendLine(FileElement(Path.Combine(globalAnalyzerConfigsDir, editorconfig), "build\\config\\"));
+            result.AppendLine(FileElement(Path.Combine(directory, editorconfig), $"build\\config\\{directoryName}"));
         }
     }
 }

eng/GenerateAnalyzerNuspec.targets

@@ -36,6 +36,7 @@
       <GenerateAnalyzerMdFile Condition="'$(GenerateAnalyzerMdFile)' == ''">true</GenerateAnalyzerMdFile>
       <GenerateAnalyzerSarifFile Condition="'$(GenerateAnalyzerSarifFile)' == ''">true</GenerateAnalyzerSarifFile>
       <GenerateAnalyzerConfigurationFile Condition="'$(GenerateAnalyzerConfigurationFile)' == ''">true</GenerateAnalyzerConfigurationFile>
+      <GenerateAnalyzerRulesMissingDocumentationFile Condition="'$(GenerateAnalyzerRulesMissingDocumentationFile)' == ''">false</GenerateAnalyzerRulesMissingDocumentationFile>
     </PropertyGroup>
 
     <PropertyGroup Condition="'$(GeneratePackagePropsFile)' == 'true'">
@@ -66,15 +67,15 @@
       <AnalyzerConfigurationFileName>Analyzer Configuration.md</AnalyzerConfigurationFileName>
     </PropertyGroup>
 
-    <MSBuild Projects="$(RepoRoot)src\Tools\GenerateAnalyzerRulesets\GenerateAnalyzerRulesets.csproj" Targets="Build">
-      <Output TaskParameter="TargetOutputs" PropertyName="_GenerateAnalyzerRulesetsPath"/>
+    <MSBuild Projects="$(RepoRoot)src\Tools\GenerateDocumentationAndConfigFiles\GenerateDocumentationAndConfigFiles.csproj" Targets="Build">
+      <Output TaskParameter="TargetOutputs" PropertyName="_GenerateDocumentationAndConfigFilesPath"/>
     </MSBuild>
 
     <ItemGroup>
       <AnalyzerRulesetAssembly Condition="'@(AnalyzerNupkgAssembly)' != '' and '@(AnalyzerRulesetAssembly)' == ''" Include="@(AnalyzerNupkgAssembly)"/>
       <AnalyzerRulesetAssembly Update="@(AnalyzerRulesetAssembly)" Condition="'%(AnalyzerRulesetAssembly.TargetFramework)' == ''" TargetFramework="$(TargetFramework)" />
     </ItemGroup>
-    <Exec Command='"$(DotNetRoot)dotnet.exe" "$(_GenerateAnalyzerRulesetsPath)" "$(_GeneratedRulesetsDir)" "$(_GeneratedEditorconfigsDir)" "$(ArtifactsBinDir)\" "$(Configuration)" "%(AnalyzerRulesetAssembly.TargetFramework)" "@(AnalyzerRulesetAssembly)" "$(PackagePropsFileDir)" "$(PackagePropsFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerDocumentationFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerSarifFileName)" "$(VersionPrefix)" $(NuspecPackageId) $(ContainsPortedFxCopRules)' />
+    <Exec Command='"$(DotNetRoot)dotnet.exe" "$(_GenerateDocumentationAndConfigFilesPath)" "$(_GeneratedRulesetsDir)" "$(_GeneratedEditorconfigsDir)" "$(ArtifactsBinDir)\" "$(Configuration)" "%(AnalyzerRulesetAssembly.TargetFramework)" "@(AnalyzerRulesetAssembly)" "$(PackagePropsFileDir)" "$(PackagePropsFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerDocumentationFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerSarifFileName)" "$(VersionPrefix)" $(NuspecPackageId) $(ContainsPortedFxCopRules) $(GenerateAnalyzerRulesMissingDocumentationFile)' />
 
     <MSBuild Projects="$(RepoRoot)src\Tools\GenerateGlobalAnalyzerConfigs\GenerateGlobalAnalyzerConfigs.csproj" Targets="Build">
       <Output TaskParameter="TargetOutputs" PropertyName="_GenerateGlobalAnalyzerConfigsPath"/>

eng/Versions.props

@@ -33,7 +33,7 @@
     <MicrosoftCodeAnalysisTestResourcesProprietaryVersion>2.0.0-pre-20160714</MicrosoftCodeAnalysisTestResourcesProprietaryVersion>
 
     <!-- Roslyn Testing -->
-    <MicrosoftCodeAnalysisTestingVersion>1.0.1-beta1.20166.3</MicrosoftCodeAnalysisTestingVersion>
+    <MicrosoftCodeAnalysisTestingVersion>1.0.1-beta1.20214.2</MicrosoftCodeAnalysisTestingVersion>
 
     <!-- Libs -->
     <SystemCollectionsImmutableVersion>1.3.1</SystemCollectionsImmutableVersion>

src/MetaCompilation.Analyzers/MetaCompilation.Analyzers.sarif

@@ -5,7 +5,7 @@
     {
       "tool": {
         "name": "MetaCompilation.Analyzers",
-        "version": "3.0.0",
+        "version": "3.3.0",
         "language": "en-US"
       },
       "rules": {

src/MetaCompilation.Analyzers/RulesMissingDocumentation.md

@@ -0,0 +1,66 @@
+## Rules without documentation
+
+Rule ID | Missing Help Link | Title |
+--------|-------------------|-------|
+MetaAnalyzer001 |  | Missing diagnostic id |
+MetaAnalyzer002 |  | Missing Initialize method |
+MetaAnalyzer003 |  | Missing register statement |
+MetaAnalyzer004 |  | Multiple registered actions |
+MetaAnalyzer005 |  | Incorrect method signature |
+MetaAnalyzer006 |  | Incorrect statement |
+MetaAnalyzer007 |  | Missing SupportedDiagnostics property |
+MetaAnalyzer008 |  | Incorrect SupportedDiagnostics property |
+MetaAnalyzer009 |  | Missing get-accessor |
+MetaAnalyzer010 |  | Too many accessors |
+MetaAnalyzer011 |  | Get accessor missing return value |
+MetaAnalyzer012 |  | SupportedDiagnostics return value incorrect |
+MetaAnalyzer013 |  | ImmutableArray incorrect |
+MetaAnalyzer014 |  | Incorrect DiagnosticDescriptor id |
+MetaAnalyzer015 |  | Missing Diagnostic id declaration |
+MetaAnalyzer016 |  | Incorrect defaultSeverity |
+MetaAnalyzer017 |  | Incorrect isEnabledByDefault |
+MetaAnalyzer018 |  | Incorrect DiagnosticDescriptor modifiers |
+MetaAnalyzer019 |  | Missing DiagnosticDescriptor |
+MetaAnalyzer020 |  | Missing if-statement extraction |
+MetaAnalyzer021 |  | If-statement extraction incorrect |
+MetaAnalyzer022 |  | Missing if-keyword extraction |
+MetaAnalyzer023 |  | Incorrect if-keyword extraction |
+MetaAnalyzer024 |  | Missing trailing trivia check |
+MetaAnalyzer025 |  | Incorrect trailing trivia check |
+MetaAnalyzer026 |  | Missing trailing trivia extraction |
+MetaAnalyzer027 |  | Incorrect trailing trivia extraction |
+MetaAnalyzer028 |  | Missing SyntaxKind check |
+MetaAnalyzer029 |  | Incorrect SyntaxKind check |
+MetaAnalyzer030 |  | Missing whitespace check |
+MetaAnalyzer031 |  | Incorrect whitespace check |
+MetaAnalyzer032 |  | Missing return |
+MetaAnalyzer033 |  | Incorrect return |
+MetaAnalyzer034 |  | Missing open parenthesis variable |
+MetaAnalyzer035 |  | Open parenthesis variable incorrect |
+MetaAnalyzer036 |  | Start span variable missing |
+MetaAnalyzer037 |  | Start span variable incorrect |
+MetaAnalyzer038 |  | End span variable missing |
+MetaAnalyzer039 |  | End span variable incorrect |
+MetaAnalyzer040 |  | Diagnostic span variable missing |
+MetaAnalyzer041 |  | Diagnostic span variable incorrect |
+MetaAnalyzer042 |  | Diagnostic location variable missing |
+MetaAnalyzer043 |  | Diagnostic location variable incorrect |
+MetaAnalyzer044 |  | Missing analysis method |
+MetaAnalyzer045 |  | Too many statements |
+MetaAnalyzer046 |  | Diagnostic variable missing |
+MetaAnalyzer047 |  | Diagnostic variable incorrect |
+MetaAnalyzer048 |  | Diagnostic report missing |
+MetaAnalyzer049 |  | Diagnostic report incorrect |
+MetaAnalyzer050 |  | Analyzer tutorial complete |
+MetaAnalyzer051 |  | Incorrect kind |
+MetaAnalyzer052 |  | Incorrect register |
+MetaAnalyzer053 |  | Incorrect arguments |
+MetaAnalyzer054 |  | Incorrect analysis method accessibility |
+MetaAnalyzer055 |  | Incorrect analysis method return type |
+MetaAnalyzer056 |  | Incorrect parameter to analysis method |
+MetaAnalyzer057 |  | Trailing trivia count missing |
+MetaAnalyzer058 |  | Trailing trivia count incorrect |
+MetaAnalyzer059 |  | ID string literal |
+MetaAnalyzer060 |  | Change default title |
+MetaAnalyzer061 |  | Change default message |
+MetaAnalyzer062 |  | Change default category |