Follow up on LDM decisions made 2022-01-26 #59229

AlekseyTs · 2022-02-03T01:19:24Z

LDM notes: https://github.com/dotnet/csharplang/blob/main/meetings/2022/LDM-2022-01-26.md
Feature spec: https://github.com/dotnet/csharplang/blob/main/proposals/utf8-string-literals.md
Test plan: #58848

LDM notes: https://github.com/dotnet/csharplang/blob/main/meetings/2022/LDM-2022-01-26.md Feature spec: https://github.com/dotnet/csharplang/blob/main/proposals/utf8-string-literals.md

RikkiGibson · 2022-02-03T02:05:24Z

It looks like the change may have broken the bootstrap build.

AlekseyTs · 2022-02-03T21:09:36Z

@cston, @dotnet/roslyn-compiler For the second review.

AlekseyTs · 2022-02-04T14:55:26Z

@cston, https://github.com/orgs/dotnet/teams/roslyn-compiler For the second review.

cston · 2022-02-04T23:46:49Z

src/Compilers/Core/CodeAnalysisTest/ObjectSerializationTests.cs

+            // PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work aroung the break -   
+            // error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'
+            writer.WriteValue((object)"YYY");
+
+            // PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work aroung the break -   
+            // error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'
+            writer.WriteValue((object)"\uD800\uDC00"); // valid surrogate pair
+
+            // PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work aroung the break -   
+            // error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'
+            writer.WriteValue((object)"\uDC00\uD800"); // invalid surrogate pair
+
+            // PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work aroung the break -   
+            // error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'
+            writer.WriteValue((object)"\uD800"); // incomplete surrogate pair


Suggested change

// PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work aroung the break -

// error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'

writer.WriteValue((object)"YYY");

// PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work aroung the break -

// error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'

writer.WriteValue((object)"\uD800\uDC00"); // valid surrogate pair

// PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work aroung the break -

// error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'

writer.WriteValue((object)"\uDC00\uD800"); // invalid surrogate pair

// PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work aroung the break -

// error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'

writer.WriteValue((object)"\uD800"); // incomplete surrogate pair

// PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work around the break -

// error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'

writer.WriteValue((object)"YYY");

// PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work around the break -

// error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'

writer.WriteValue((object)"\uD800\uDC00"); // valid surrogate pair

// PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work around the break -

// error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'

writer.WriteValue((object)"\uDC00\uD800"); // invalid surrogate pair

// PROTOTYPE(UTF8StringLiterals) : An explicit cast is added to work around the break -

// error CS0121: The call is ambiguous between the following methods or properties: 'ObjectWriter.WriteValue(object ?)' and 'ObjectWriter.WriteValue(ReadOnlySpan<byte>)'

writer.WriteValue((object)"\uD800"); // incomplete surrogate pair

``` #Closed

cston · 2022-02-04T23:48:41Z

src/Compilers/CSharp/Portable/CSharpResources.resx

@@ -6947,4 +6947,7 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
  <data name="IDS_FeatureUTF8StringLiterals" xml:space="preserve">
    <value>Utf8 String Literals</value>
  </data>
+  <data name="ERR_ExpressionTreeContainsUTF8StringLiterals" xml:space="preserve">
+    <value>An expression tree may not contain UTF-8 string conversion or literal.</value>


UTF-8

Consider using consistent form for these three messages - perhaps "UTF8". #Closed

cston · 2022-02-05T00:07:46Z

src/Compilers/CSharp/Test/Semantic/Semantics/Utf8StringsLiteralsTests.cs

+                );
+        }
+
+        [ConditionalFact(typeof(CoreClrOnly))]


[ConditionalFact(typeof(CoreClrOnly))]

[Fact] #Closed

cston · 2022-02-05T00:11:32Z

src/Compilers/CSharp/Test/Semantic/Semantics/Utf8StringsLiteralsTests.cs

@@ -1829,7 +1953,8 @@ static void Main()
 ";
            var comp = CreateCompilation(source, targetFramework: TargetFramework.NetCoreApp, options: TestOptions.DebugExe);

-            CompileAndVerify(comp, expectedOutput: @"ReadOnlySpan").VerifyDiagnostics();
+            // PROTOTYPE(UTF8StringLiterals) : Add an entry in "docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md"?
+            CompileAndVerify(comp, expectedOutput: @"array").VerifyDiagnostics();


@"array"

Since this is a change in behavior, please include a corresponding compilation using TestOptions.Regular10. (Will it report "feature is in preview"?) #Closed

cston · 2022-02-05T00:16:59Z

src/Compilers/CSharp/Test/Semantic/Semantics/Utf8StringsLiteralsTests.cs

+            var comp = CreateCompilation(source, targetFramework: TargetFramework.NetCoreApp, options: TestOptions.DebugExe);
+
+            // PROTOTYPE(UTF8StringLiterals) : Add an entry in "docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md"?
+            CompileAndVerify(comp, expectedOutput: @"array").VerifyDiagnostics();


CompileAndVerify(comp, expectedOutput: @"array").VerifyDiagnostics();

Since this is a change in behavior, please include a corresponding compilation using TestOptions.Regular10. #Closed

cston · 2022-02-05T00:19:49Z

src/Compilers/CSharp/Test/Syntax/Parsing/UTF8StringLiteralsParsingTests.cs

@@ -216,7 +272,7 @@ public void Errors_07()
        }

        [Fact]
-        public void Errors_08()
+        public void Errors_07()
        {
            // The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_07.


Suggested change

// The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_07.

// The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_06.

``` #Closed

cston · 2022-02-05T00:20:51Z

src/Compilers/CSharp/Test/Syntax/Parsing/UTF8StringLiteralsParsingTests.cs

-        }
-
-        [Fact]
-        public void Errors_05()
        {
            // The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_06.


Suggested change

// The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_06.

// The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_05.

``` #Closed

cston · 2022-02-05T00:22:00Z

        // The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_07.

Errors_06

In reply to: 1030458751

Refers to: src/Compilers/CSharp/Test/Syntax/Parsing/UTF8StringLiteralsParsingTests.cs:179 in 5a41f5a. [](commit_id = 5a41f5a, deletion_comment = False)

cston · 2022-02-05T00:22:44Z

src/Compilers/CSharp/Test/Syntax/Parsing/UTF8StringLiteralsParsingTests.cs

+        }
+
+        [Fact]
+        public void Errors_16()
        {
            // The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_06.


Suggested change

// The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_06.

// The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_05.

``` #Closed

AlekseyTs · 2022-02-08T16:15:56Z

@cston I think I addressed your feedback. Please review.

Follow up on LDM decisions made 2022-01-26

2da0033

LDM notes: https://github.com/dotnet/csharplang/blob/main/meetings/2022/LDM-2022-01-26.md Feature spec: https://github.com/dotnet/csharplang/blob/main/proposals/utf8-string-literals.md

AlekseyTs added Area-Compilers New Feature - Utf8StringLiterals labels Feb 3, 2022

AlekseyTs requested review from RikkiGibson, cston and a team February 3, 2022 01:19

RikkiGibson approved these changes Feb 3, 2022

View reviewed changes

Fix bootstrap build

5a41f5a

cston reviewed Feb 4, 2022

View reviewed changes

cston reviewed Feb 5, 2022

View reviewed changes

PR feedback

58fbd74

cston approved these changes Feb 8, 2022

View reviewed changes

AlekseyTs enabled auto-merge (squash) February 8, 2022 17:06

AlekseyTs merged commit 94bfc22 into dotnet:features/Utf8StringLiterals Feb 8, 2022

runfoapp bot mentioned this pull request Feb 8, 2022

Failure in CSharpCodeActions.GFUFuzzyMatchAfterRenameTrackingAndAfterGenerateType #57423

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Follow up on LDM decisions made 2022-01-26 #59229

Follow up on LDM decisions made 2022-01-26 #59229

AlekseyTs commented Feb 3, 2022 •

edited by jcouv

Loading

RikkiGibson commented Feb 3, 2022

AlekseyTs commented Feb 3, 2022

AlekseyTs commented Feb 4, 2022

cston Feb 4, 2022 •

edited

Loading

cston Feb 4, 2022 •

edited

Loading

cston Feb 5, 2022 •

edited

Loading

cston Feb 5, 2022 •

edited

Loading

cston Feb 5, 2022 •

edited

Loading

cston Feb 5, 2022 •

edited

Loading

cston Feb 5, 2022 •

edited

Loading

cston commented Feb 5, 2022 •

edited by AlekseyTs

Loading

cston Feb 5, 2022 •

edited

Loading

AlekseyTs commented Feb 8, 2022

	// The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_07.
	// The behavior is consistent with how type suffixes are handled on numeric literals, see Errors_06.
	``` #Closed

Follow up on LDM decisions made 2022-01-26 #59229

Follow up on LDM decisions made 2022-01-26 #59229

Conversation

AlekseyTs commented Feb 3, 2022 • edited by jcouv Loading

RikkiGibson commented Feb 3, 2022

AlekseyTs commented Feb 3, 2022

AlekseyTs commented Feb 4, 2022

cston Feb 4, 2022 • edited Loading

Choose a reason for hiding this comment

cston Feb 4, 2022 • edited Loading

Choose a reason for hiding this comment

cston Feb 5, 2022 • edited Loading

Choose a reason for hiding this comment

cston Feb 5, 2022 • edited Loading

Choose a reason for hiding this comment

cston Feb 5, 2022 • edited Loading

Choose a reason for hiding this comment

cston Feb 5, 2022 • edited Loading

Choose a reason for hiding this comment

cston Feb 5, 2022 • edited Loading

Choose a reason for hiding this comment

cston commented Feb 5, 2022 • edited by AlekseyTs Loading

cston Feb 5, 2022 • edited Loading

Choose a reason for hiding this comment

AlekseyTs commented Feb 8, 2022

AlekseyTs commented Feb 3, 2022 •

edited by jcouv

Loading

cston Feb 4, 2022 •

edited

Loading

cston Feb 4, 2022 •

edited

Loading

cston Feb 5, 2022 •

edited

Loading

cston Feb 5, 2022 •

edited

Loading

cston Feb 5, 2022 •

edited

Loading

cston Feb 5, 2022 •

edited

Loading

cston Feb 5, 2022 •

edited

Loading

cston commented Feb 5, 2022 •

edited by AlekseyTs

Loading

cston Feb 5, 2022 •

edited

Loading