Create new vsix for x64 .NET ServiceHub services #65471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+524
to
+527
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Roslyn.VisualStudio.ServiceHub.Setup.x64", "src\VisualStudio\Setup.ServiceHub\x64\Roslyn.VisualStudio.ServiceHub.Setup.x64.csproj", "{A900A17C-3FD1-4892-8528-51A967E77339}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Remote.ServiceHub.CoreComponents.x64", "src\Workspaces\Remote\ServiceHub.CoreComponents\x64\Microsoft.CodeAnalysis.Remote.ServiceHub.CoreComponents.x64.csproj", "{3ABBDFF7-ED76-4EA3-840E-85E3274302B0}" | ||
| EndProject |
There was a problem hiding this comment.
Why do we need two projects here?
There was a problem hiding this comment.
"Microsoft.CodeAnalysis.Remote.ServiceHub.CoreComponents.x64" is used to collect all dependencies and crossgen them. "Roslyn.VisualStudio.ServiceHub.Setup.x64" is to create the vsix. Maybe there's a better way to do it w/o multiple projects, but I have no idea how :(
genlu
changed the title
genlu
changed the title
tmat
reviewed
May 3, 2023
| "Microsoft.NETCore.App.Runtime.win-{arch}" | ||
| "Microsoft.WindowsDesktop.App.Runtime.win-{arch}" | ||
| --> | ||
| <PackageReference Include="Microsoft.NETCore.App.crossgen2.win-x64" Version="$(MicrosoftNETCoreAppcrossgen2winx64Version)" Condition="'$(GenerateReadyToRun)' == 'true'" ExcludeAssets="all" PrivateAssets="all" GeneratePathProperty="true" /> |
There was a problem hiding this comment.
yea, you are right. I will fix it in the follow up when adding arm64 support. Thanks!
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prerequisite of #64610
link to validation insertion (with additional setup authoring change on VS side)
https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/468984