Val/revert66430 17.6 #67849
Merged
Val/revert66430 17.6 #67849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
AlekseyTs
reviewed
May 3, 2023
NuGet.config
Outdated
| @@ -12,7 +12,9 @@ | |||
| <add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" /> | |||
| <add key="nuget-build" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/nuget-build/nuget/v3/index.json" /> | |||
| <add key="vssdk" value="https://pkgs.dev.azure.com/azure-public/vside/_packaging/vssdk/nuget/v3/index.json" /> | |||
| <add key="vssdk-archived" value="https://pkgs.dev.azure.com/azure-public/vside/_packaging/vssdk-archived/nuget/v3/index.json" /> | |||
There was a problem hiding this comment.
VS has changed the way they handle NuGet feeds since we last inserted this branch. This is a cherry pick from main that is required to build this branch.
There was a problem hiding this comment.
This is a cherry pick from main that is required to build this branch.
The change shouldn't be part of this PR, unless it is specific to the change we are making. Which it sounds like it is not related.
There was a problem hiding this comment.
Ok, I can break it out into two PRs, but they'll be inserted in the same VS insertion either way. We can't insert without the feed change.
|
Done with review pass (commit 2). It looks like CI jobs are failing, BTW. |
jaredpar
approved these changes
May 3, 2023
…tnet#66430)" This reverts commit ec485d1.
chsienki
force-pushed
the
val/revert66430_17.6
branch
from
56f2c1e
to
ea93e75
Compare
|
Updated to only include the single commit |
jcouv
removed
the
untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #67808 (a revert PR) to 17.6 for servicing
Corresponding DevDiv issue: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1733125