Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of additional overloads on lambda parameter's member recommendations #68028

Merged
merged 2 commits into from
May 4, 2023

Conversation

jhinder
Copy link
Contributor

@jhinder jhinder commented Apr 29, 2023

Fixes #61343.

The lambda parameter's type was added to the array twice, causing its members to be considered twice too. This resulted in the wrong number of additional overloads being shown in the completion item's tooltip ($2n-1$ instead of $n-1$).
This fix makes the addition of the type symbol conditional so that it doesn't appear more than once in the array of type symbols.

@jhinder jhinder requested a review from a team as a code owner April 29, 2023 22:16
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 29, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 29, 2023
@genlu genlu removed the untriaged Issues and PRs which have not yet been triaged by a lead label May 4, 2023
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@genlu genlu merged commit a959bbd into dotnet:main May 4, 2023
@ghost ghost added this to the Next milestone May 4, 2023
@jhinder jhinder deleted the fix/61343-lambda-member-overloads branch May 4, 2023 20:45
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntelliSense/Auto-complete off-by-one on overload count on members of lambda argument objects
3 participants