Fix up implementation for parameterless requests. #68077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
What would be the best way to test this? Apparently this code path is not tested right now. |
dibarbet
reviewed
May 3, 2023
| { | ||
| public static VoidReturn Instance = new(); | ||
| public static NoValue Instance = new(); |
There was a problem hiding this comment.
I couldn't find anyone else using this, so this might not need a dual insertion
There was a problem hiding this comment.
It's internal, so shouldn't be used, no?
There was a problem hiding this comment.
I believe everyone using this has IVTs
The only way I know is to create a mock client in unit test, and find a scenario and test it. but it depends on if you could find a lsp scenario hitting this |
|
@dibarbet Tests added. |
dibarbet
approved these changes
May 4, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.