Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move potential expensive task of ItemManager to ThreadPool #68082

Merged
merged 1 commit into from
May 4, 2023

Conversation

genlu
Copy link
Member

@genlu genlu commented May 3, 2023

Editor calls our async-completion extension points on a special high-priority thread, which is also used for cancelling long-running sessions. We have seen from the trace that the PLinq.ForAll is synchronously waiting on this special thread, which would cause delay to the cancellation.

Fix AB#1275190

@genlu genlu requested a review from a team as a code owner May 3, 2023 22:51
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 3, 2023
@genlu genlu enabled auto-merge May 4, 2023 00:12
@genlu genlu merged commit c231d70 into dotnet:main May 4, 2023
@ghost ghost added this to the Next milestone May 4, 2023
@genlu genlu deleted the MoveToThreadpool branch May 4, 2023 17:49
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants