Avoid task allocations for TextDocument.GetTextAsync #68090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
sharwell
force-pushed
the
value-task-cleanup
branch
from
78ec53f
to
b4f4443
Compare
Updates production code to use GetValueTaskAsync or GetTextSynchronously, as appropriate, to avoid task allocations in a call to GetTextAsync.
sharwell
force-pushed
the
value-task-cleanup
branch
from
b4f4443
to
020a2a4
Compare
sharwell
commented
May 4, 2023
| var sourceText = await document.GetTextAsync().ConfigureAwait(false); | ||
| var textContainer = sourceText.Container; | ||
| return textContainer.TryGetTextBuffer(); | ||
| }); |
There was a problem hiding this comment.
📝 This is the only one that changed significantly
ghost
added this to the |
|
||
| return new ValueTask<SourceText>(document.GetTextAsync(cancellationToken)); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
i would be supportive of you makign an API proposal for this and going through public API review as well. (not blocking this PR of course).
CyrusNajmabadi
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates production code to use GetValueTaskAsync or GetTextSynchronously, as appropriate, to avoid task allocations in a call to GetTextAsync.