Move a few types related to pattern matching to be structs instead of classes. #68101
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| namespace Microsoft.CodeAnalysis.FindSymbols | |||
| { | |||
| internal class SearchQuery : IDisposable | |||
| internal readonly struct SearchQuery : IDisposable | |||
There was a problem hiding this comment.
was very close to being able to make the whole host of these into ref-struct types. But SearchQuery itself is captured into the heap through teh use of a "predicate" delegate it hands out to the compiler to do some work. So for now these have to be normal structs unfortunately.
|
|
||
| return array; | ||
| } | ||
|
|
||
| public void Dispose() | ||
| { | ||
| if (_sourceLowerCaseCharacters == null) | ||
| throw new ObjectDisposedException(nameof(EditDistance)); |
There was a problem hiding this comment.
📝 I don't think this is working the way one would expect. This would only throw for the case of default(EditDistance), so InvalidOperationException might be more appropriate.
There was a problem hiding this comment.
you are correct. will fix.
| using System.Diagnostics; | ||
|
|
||
| namespace Roslyn.Utilities | ||
| { | ||
| internal class WordSimilarityChecker | ||
| internal struct WordSimilarityChecker : IDisposable |
There was a problem hiding this comment.
💡 Likely want either [NonCopyable] or readonly
There was a problem hiding this comment.
yup. needs to be NonCopyable.
ghost
added this to the 
No description provided.