Use new helper type for initializing a value type field only once, and in a threadsafe manner. #71013
Conversation
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@dotnet/roslyn-compiler we noticed these few places that could potentially benefit moving off of StrongBox to the SingleInitNullable type. That type is the same size as It's up to you if you want to take this or not. Feel free to close out if you're happy with the code as is. |
| @@ -34,6 +34,10 @@ private static bool TryGetTargetScope(SuppressMessageInfo info, out TargetScope | |||
| private readonly Compilation _compilation; | |||
| private GlobalSuppressions? _lazyGlobalSuppressions; | |||
| private readonly ConcurrentDictionary<ISymbol, ImmutableDictionary<string, SuppressMessageInfo>> _localSuppressionsBySymbol; | |||
|
|
|||
| // These are StrongBoxes because 'null' is a valid symbol value to compute for these, and as such, we can't use | |||
| // the null value to indicate 'not yet computed'. | |||
There was a problem hiding this comment.
feel free to delete this comment as well. i just thought it might be helpful for someone asking why a reference type needed to be wrapped in a strongbox.
IMO though, this should use Optional<T> But we'd also need a way to initialize that in an interlocked fashion.
| @@ -27,7 +27,7 @@ internal class BuiltInOperators | |||
| //actual lazily-constructed caches of built-in operators. | |||
| private ImmutableArray<UnaryOperatorSignature>[] _builtInUnaryOperators; | |||
| private ImmutableArray<BinaryOperatorSignature>[][] _builtInOperators; | |||
| private StrongBox<BinaryOperatorSignature> _builtInUtf8Concatenation; | |||
| private SingleInitNullable<BinaryOperatorSignature> _builtInUtf8Concatenation; | |||
There was a problem hiding this comment.
note: this also avoids a heap allocation here.
| @@ -754,7 +745,7 @@ bool isGeneratedHeuristic() | |||
|
|
|||
| private CSharpLineDirectiveMap? _lazyLineDirectiveMap; | |||
| private CSharpPragmaWarningStateMap? _lazyPragmaWarningStateMap; | |||
| private StrongBox<NullableContextStateMap>? _lazyNullableContextStateMap; | |||
| private SingleInitNullable<NullableContextStateMap> _lazyNullableContextStateMap; | |||
There was a problem hiding this comment.
note: this also avoids a heap allocation here.
|
@dotnet/roslyn-compiler @333fred @RikkiGibson ptal. |
|
@jaredpar ptal. :) |
ghost
added this to the 
No description provided.