Fix simplify lambda expression with unrelated assignment in other method #71324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Dec 18, 2023
| var outermostBody = invokedExpression.AncestorsAndSelf().LastOrDefault( | ||
| n => n is BlockSyntax or ArrowExpressionClauseSyntax or AnonymousFunctionExpressionSyntax or GlobalStatementSyntax); | ||
| if (outermostBody is null or GlobalStatementSyntax) | ||
| outermostBody = syntaxTree.GetRoot(cancellationToken); |
There was a problem hiding this comment.
the prior walk always hit the compilation unit. which meant that we were always checking everything (Even unrelated code). now we keep walking up, and only go to the compilation unit if we were in a global statement.
akhera99
approved these changes
Dec 18, 2023
ghost
added this to the 
sharwell
reviewed
Dec 19, 2023
| var outermostBody = invokedExpression.AncestorsAndSelf().Last( | ||
| n => n is BlockSyntax or ArrowExpressionClauseSyntax or AnonymousFunctionExpressionSyntax or CompilationUnitSyntax); | ||
| var outermostBody = invokedExpression.AncestorsAndSelf().LastOrDefault( | ||
| n => n is BlockSyntax or ArrowExpressionClauseSyntax or AnonymousFunctionExpressionSyntax or GlobalStatementSyntax); |
There was a problem hiding this comment.
Do we need to consider field or property initializers here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71300