Escape record keywords
#74227
Open
Escape record keywords
#74227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
333fred
reviewed
Jul 1, 2024
| @@ -991,6 +991,8 @@ public static SyntaxKind GetKeywordKind(string text) | |||
| return SyntaxKind.UsingKeyword; | |||
| case "class": | |||
| return SyntaxKind.ClassKeyword; | |||
| case "record": | |||
| return SyntaxKind.RecordKeyword; | |||
There was a problem hiding this comment.
We can't make this appear as keyword kind. We likely need to special case it in the visitor.
SteveDunn
commented
Jul 2, 2024
| @@ -127,7 +127,7 @@ private static bool IsEscapable(SymbolDisplayPartKind kind) | |||
| private static string EscapeIdentifier(string identifier) | |||
| { | |||
| var kind = SyntaxFacts.GetKeywordKind(identifier); | |||
| return kind == SyntaxKind.None | |||
| return kind == SyntaxKind.None && !StringComparer.Ordinal.Equals(identifier, "record") | |||
There was a problem hiding this comment.
I could be wrong again about this, but this seems the next most logical place to always escape record identifiers
There was a problem hiding this comment.
Almost. I think we likely want this, but we also want to only escape some kinds. Let's add a parallel to IsEscapable specifically for records; we only want to escape type names, as that's all we warn on. We can then pass that flag into EscapeIdentifier and adjust this second half of the condition appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #74117 where it was decided that records should be escaped, even though they're not keywords, as it is the safer thing to do.
See other PR #74125