Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build for FEATURE_GDBJIT #104380

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

cshung
Copy link
Member

@cshung cshung commented Jul 3, 2024

I tried to play around with FEATURE_GDBJIT, without this change, it doesn't even compile.

This fixed the build, but debugging with gdb is still not working, not sure what is wrong.

@AaronRobinsonMSFT
Copy link
Member

Can you share the build failures you are seeing?

@cshung
Copy link
Member Author

cshung commented Jul 3, 2024

Can you share the build failures you are seeing?

Sure, here it is:

  In file included from /home/andrewau/git/runtime/src/coreclr/vm/prestub.cpp:45:
  /home/andrewau/git/runtime/src/coreclr/vm/customattribute.h:13:11: error: redefinition of 'Attribute' as different kind of symbol
  namespace Attribute
            ^
  /home/andrewau/git/runtime/src/coreclr/vm/../inc/llvm/Dwarf.h:125:6: note: previous definition is here
  enum Attribute : uint16_t {

@cshung cshung merged commit 8432f0d into dotnet:main Jul 3, 2024
89 checks passed
@cshung cshung deleted the public/fix-gdb-jit branch July 3, 2024 22:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants