Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncMethodBuilderOverride and PoolingAsyncValueTaskMethodBuilders #50116

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Mar 23, 2021

Fixes #49903
Closes #13633
cc: @jcouv

Note that this removes from the existing builders the experiment we shipped in .NET 5 that lets you opt the process into pooling all async ValueTask methods via an environment variable. Code will opt back in to the pooling on a case-by-case basis using these types, once the C# 10 compiler's support for overrides is in place.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Mar 23, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #49903
cc: @jcouv

Note that this removes from the existing builders the experiment we shipped in .NET 5 that lets you opt the process into pooling all async ValueTask methods via an environment variable. Code will opt back in to the pooling on a case-by-case basis using these types, once the C# 10 compiler's support for overrides is in place.

Author: stephentoub
Assignees: -
Labels:

area-System.Threading.Tasks

Milestone: 6.0.0

@stephentoub
Copy link
Member Author

cc: @benaadams

@stephentoub
Copy link
Member Author

@adamsitnik @carlossanlop @Jozkee I guess this is your domain now? Mind reviewing when you get a chance? Thanks.

@benaadams
Copy link
Member

once the C# 10 compiler's support for overrides is in place.

Looking forward it it 😁

@stephentoub
Copy link
Member Author

@benaadams, anything your keen eyes think should be done differently here?

Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot cleaner than before; looking forward to the possibilities

@stephentoub stephentoub merged commit 2784aad into dotnet:main Mar 31, 2021
@stephentoub stephentoub deleted the poolingbuilder branch March 31, 2021 13:30
@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants