Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh card image after click #320

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Refresh card image after click #320

merged 1 commit into from
Feb 25, 2019

Conversation

HerveH44
Copy link
Contributor

Closes #314

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-320 February 18, 2019 15:53 Inactive
@tooomm
Copy link
Contributor

tooomm commented Feb 18, 2019

Hmm, I see no difference between
https://dr4ft.info and https://beta-dr4ft-pr-320.herokuapp.com/

The preview pictures used to refresh when you click at the top card on the pile (the one you see completely).
But it doesn't work if you click on the bottom one (the one which name is only visible).

With this PR that behavior seems not to change?

Which change do you expect from this PR exactly @HerveH44 ?
I can then retest again 👍

@HerveH44
Copy link
Contributor Author

HerveH44 commented Feb 18, 2019

Ok, it doesn't work for me either... checking it

@HerveH44
Copy link
Contributor Author

That's really weird, I can't find a way to understand how to fix this. There's no event on the card where the mouse is after the previous card disappeared...

I feel that's out of my reach ....

@tooomm
Copy link
Contributor

tooomm commented Feb 20, 2019

Hmm... Why does it work when you click the top card, but not any other card?!

@HerveH44
Copy link
Contributor Author

That's a mystery .... ;) !

@ZeldaZach
Copy link
Member

What do we want to do with this?

@HerveH44
Copy link
Contributor Author

As for me, i'd push as it is. I can't do better than that ...

@ZeldaZach ZeldaZach merged commit 492976c into master Feb 25, 2019
@ZeldaZach ZeldaZach deleted the refresh_card branch February 25, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants