-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer hud + npm run start-dev #346
Conversation
Thanks! I love the idea and I was wondering how to do it. I'll check the code as soon as I can. I would suggest though to add a bit of CSS to make it nicer. I feel that like that it's barely noticeable. About nodemon I'm more doubtful : what about webpack dev-server? Isn't it exactly the same thing? Look at "npm run dev-server", I installed it a while ago and I use it from time to time. It works well |
So i tested this out and I do like it, but like Herve said the CSS needs to be better. Maybe make it more noticeable / fancy so people know what they're looking at as I had to actively look for it. |
@HerveH44 About the nodemon: As far as I know, webpack-dev-server only reloads for client side code change and has an identical effect to running webpack with a -w flag. Nodemon will restart the server in the event of server side code changes. Can someone attach a screenshot of what they see for the HUD timer? I'm on MacOS and chrome, so it make look different but on my screen it is quite evident where it is and what the timer indicates. |
This is how it looks for me on Windows with Firefox: It's a nice improvement in my opinion, even though it's not perfectly stressed. Something like the floating box in #345 in one of the upper or bottom corners would be more visible. |
talked with herve, he agreed nodemon+webpack -w is strictly better than webpack-dev-server
I've never used nodemon but I'm more than happy to use it! Webpack dev-server is not useful anymore I guess! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could also delete all the informations about dev-server setup in webpack.config files
Took a different approach, should be good cross browser/device. Let me know what you guys think. |
Took a different approach again. @ZeldaZach New commits should fix those issues + look slightly better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job! This is a great addition :)
Hm, looks like your browser is overriding the global font we are using on the site. I'll try to adjust the width to be font-agnostic, but I could always find a fallback font that works with the size of the panel if that doesn't work. |
@tooomm The chat was cutting off the config boxes on smaller screens so we added a wrap around. I can give those elements a bit of margin to prevent any overlap. |
Fix #16
Locks pack timer to top left of screen when user scrolls down.
This way users can keep track of how much time they have left to pick when they are scrolled down the page.
Added nodemon (as a dev dependency) and npm run start-dev so server / client detects changes and reloads for dev purposes.