Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer hud + npm run start-dev #346

Merged
merged 19 commits into from
Feb 25, 2019
Merged

Timer hud + npm run start-dev #346

merged 19 commits into from
Feb 25, 2019

Conversation

benjaminpwagner
Copy link
Contributor

@benjaminpwagner benjaminpwagner commented Feb 22, 2019

Fix #16

Locks pack timer to top left of screen when user scrolls down.

This way users can keep track of how much time they have left to pick when they are scrolled down the page.

Added nodemon (as a dev dependency) and npm run start-dev so server / client detects changes and reloads for dev purposes.

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 22, 2019 20:16 Inactive
@HerveH44
Copy link
Contributor

HerveH44 commented Feb 22, 2019

Thanks! I love the idea and I was wondering how to do it. I'll check the code as soon as I can. I would suggest though to add a bit of CSS to make it nicer. I feel that like that it's barely noticeable.

About nodemon I'm more doubtful : what about webpack dev-server? Isn't it exactly the same thing? Look at "npm run dev-server", I installed it a while ago and I use it from time to time. It works well

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 22, 2019 21:34 Inactive
@ZeldaZach
Copy link
Member

So i tested this out and I do like it, but like Herve said the CSS needs to be better. Maybe make it more noticeable / fancy so people know what they're looking at as I had to actively look for it.

@benjaminpwagner
Copy link
Contributor Author

benjaminpwagner commented Feb 22, 2019

@HerveH44 About the nodemon: As far as I know, webpack-dev-server only reloads for client side code change and has an identical effect to running webpack with a -w flag. Nodemon will restart the server in the event of server side code changes.

Can someone attach a screenshot of what they see for the HUD timer? I'm on MacOS and chrome, so it make look different but on my screen it is quite evident where it is and what the timer indicates.

@tooomm
Copy link
Contributor

tooomm commented Feb 24, 2019

This is how it looks for me on Windows with Firefox:
win-ff

It's a nice improvement in my opinion, even though it's not perfectly stressed.

Something like the floating box in #345 in one of the upper or bottom corners would be more visible.

talked with herve, he agreed nodemon+webpack -w is strictly better than webpack-dev-server
@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 16:30 Inactive
@HerveH44
Copy link
Contributor

I've never used nodemon but I'm more than happy to use it! Webpack dev-server is not useful anymore I guess!

Copy link
Contributor

@HerveH44 HerveH44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could also delete all the informations about dev-server setup in webpack.config files

public/src/game/PlayersPanel.jsx Outdated Show resolved Hide resolved
@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 16:42 Inactive
@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 18:01 Inactive
@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 18:05 Inactive
@benjaminpwagner
Copy link
Contributor Author

So I had to use relative distances to get the timer hud where I wanted on scroll down.

Is it showing up here for everyone else?

image

@tooomm
Copy link
Contributor

tooomm commented Feb 25, 2019

Windows 10
Firefox 65
1366x768

There are several issues for me:

  • timer in the middle of the page
    timer

  • timer freezes sometimes
    timer2

  • chat overlays and cuts timer off
    timer3

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 20:32 Inactive
@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 20:32 Inactive
@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 20:35 Inactive
@benjaminpwagner
Copy link
Contributor Author

Took a different approach, should be good cross browser/device. Let me know what you guys think.

@ZeldaZach
Copy link
Member

Interesting approach. Getting better, but not perfect. when you scroll down, the cards shift.

screenshot 2019-02-25 15 54 58

screenshot 2019-02-25 15 54 56

@ZeldaZach
Copy link
Member

ZeldaZach commented Feb 25, 2019

Also...
screenshot 2019-02-25 15 56 15

Seems to glitch out when I try to scroll down super far to my Main/Side/Junk boards

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 22:14 Inactive
@benjaminpwagner
Copy link
Contributor Author

Took a different approach again.

@ZeldaZach New commits should fix those issues + look slightly better.

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 22:34 Inactive
@ZeldaZach
Copy link
Member

Getting better for sure! Still some issues, see screenshots

screenshot 2019-02-25 17 35 22

screenshot 2019-02-25 17 35 13

screenshot 2019-02-25 17 35 06

screenshot 2019-02-25 17 34 59

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 22:46 Inactive
@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 22:55 Inactive
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job! This is a great addition :)

@HerveH44
Copy link
Contributor

image

@benjaminpwagner
Copy link
Contributor Author

Hm, looks like your browser is overriding the global font we are using on the site.

I'll try to adjust the width to be font-agnostic, but I could always find a fallback font that works with the size of the panel if that doesn't work.

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-346 February 25, 2019 23:12 Inactive
@tooomm
Copy link
Contributor

tooomm commented Feb 25, 2019

This is turning out nicely!
I also tested it on a tablet with smaller screen, but higher resolution without issues.

What does change now is that the segments/blocks (Players, Game and Settings...) get regrouped once the chat is displayed on smaller screens. The boxes overlay each other a bit in that case:
timer

@benjaminpwagner
Copy link
Contributor Author

@tooomm The chat was cutting off the config boxes on smaller screens so we added a wrap around. I can give those elements a bit of margin to prevent any overlap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants