-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pool generation #349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tooomm can you try with the last build? I understood that heroku didn't use the last version of NodeJS! |
No error now! :) |
ZeldaZach
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a big baby. I rewrote the part where the server creates the pool (packs of cards) to have a specific entry for every type of game we handle.
I haven't touched at the packs creation in se (with all the specific rules depending of the set), just clarified how we create a cube pool, normal pool or chaos pool.
Closes #68
I added the mode chaos sealed. It takes the same parameters as chaos draft.
Closes #25
I then pushed a little bit to introduce "cubePoolSize" a new variable to adjust the number of cards a cube player can have in his sealed.
Closes #27
In the end I also added the cube hash requested by @dev-id to the draft cap. I used md5, is it
Closes #350
I also cleaned up a bit code when I saw there was something old (readyToStart feature parts for example)