program: settle_pnls that handles invalid oracle and efficient cus #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispheaney
commented
Apr 25, 2024
| msg!("User has no unsettled pnl for market {}", market_index); | ||
| return Ok(()); | ||
| let msg = format!("User has no unsettled pnl for market {}", market_index); | ||
| return mode.result(ErrorCode::NoUnsettledPnl, &msg); |
There was a problem hiding this comment.
is it bad these dont always return OK? do we need update_pool_balances to go through above?
There was a problem hiding this comment.
only the 'MUST' will cause update_pool_balances to not go through? think its fine to just have 'TRY' allow that
crispheaney
commented
May 27, 2024
programs/drift/src/controller/pnl.rs
Outdated
| "User must settle their own unsettled pnl when its positive and pnl pool not in excess" | ||
| )?; | ||
| let user_must_settle_themself = pnl_to_settle_with_user > 0 | ||
| && max_pnl_pool_excess < 0 |
There was a problem hiding this comment.
- low chance excess is exactly = 0, even so not sure its necessary since theres no incentive for settle run
0xbigz
reviewed
May 28, 2024
| return mode.result( | ||
| ErrorCode::InsufficientCollateralForSettlingPNL, | ||
| "Does not meet margin requirement", | ||
| ); |
There was a problem hiding this comment.
should market_index info get propagated if errors get hit for logs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.