19/amm-jit-base-amount-fix #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xbigz
reviewed
Dec 8, 2022
|
|
||
| let (base_asset_amount_fulfilled, quote_asset_amount) = calculate_fill_for_matched_orders( | ||
| base_asset_amount_left_to_fill, | ||
| maker_base_asset_amount, |
There was a problem hiding this comment.
so this was the key issue identified and remedied here? maker amount for match is now whatever the maker has offered rather than the taker's amount leftover
crispheaney
reviewed
Dec 8, 2022
| taker, | ||
| taker_stats, | ||
| taker_order_index, | ||
| let taker_base_asset_amount_left_to_fill = |
There was a problem hiding this comment.
i think we might be able to avoid all of this nesting if instead of calculating taker_base_asset_amount_left_to_fill, we just pull the base_asset_amount_unfilled off of the taker order after the jit block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.