Bigz/update amm revenue pool logic #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispheaney
reviewed
Mar 21, 2023
tests/delistMarket.ts
Outdated
| @@ -614,7 +614,9 @@ describe('delist market', () => { | |||
| 'totalExchangeFee:', | |||
| marketAfter.amm.totalExchangeFee.toString() | |||
| ); | |||
| assert(marketAfter.amm.feePool.scaledBalance.eq(new BN(21567000))); | |||
| // assert(marketAfter.amm.feePool.scaledBalance.eq(new BN(21567000))); | |||
| market | ||
| .insurance_claim | ||
| .quote_settled_insurance | ||
| .safe_add(market.insurance_claim.quote_max_insurance)? |
There was a problem hiding this comment.
both numbers are positive cumulative numbers for insurance
cumulative liquidation fees are only given for revenue pool up to the current external insurance levels provided + net losses already paid for by external insurance
| .safe_sub(market.amm.total_fee_withdrawn.cast()?)? | ||
| let fee_pool_threshold = amm_fee_pool_token_amount_after | ||
| .saturating_sub( | ||
| FEE_POOL_TO_REVENUE_POOL_THRESHOLD.safe_add(market.amm.total_social_loss)?, |
There was a problem hiding this comment.
why do you add social loss here?
There was a problem hiding this comment.
if a market has had social loss, its indication it needs to maintain a larger fee pool for internal insurance (rather than giving to external insurance)
crispheaney
added a commit
that referenced
this pull request
Mar 23, 2023
This reverts commit abb34e4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.