Bigz/perp lp jit #448
Merged
Bigz/perp lp jit #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispheaney
reviewed
May 10, 2023
crispheaney
reviewed
May 15, 2023
| @@ -1687,7 +1690,7 @@ pub fn fulfill_perp_order_with_amm( | |||
| fee_structure: &FeeStructure, | |||
| override_base_asset_amount: Option<u64>, | |||
| override_fill_price: Option<u64>, | |||
| split_with_lps: bool, | |||
| liquidity_split: AMMLiquiditySplit, | |||
There was a problem hiding this comment.
i feel like override_base_asset_amount, override_fill_price and liquidity_split are all related, maybe we can merge them somehow so it's clearer how they're related
There was a problem hiding this comment.
think adding params to AMMLiquiditySplit is a nice-to-have future task
* sdk: start spl-token dependency upgrade * update tests to use spl-token 0.3.7 * fix driftClient test * fix whitelist test * fix unused import
* sdk: add IVersionedWallet, rename jupiter args, make loadKeypair support more private key types * dlob: add estimateFillWithExactBaseAmount * jupiter client decompile message fix * fix docstring * estimateFillWithExactBaseAmount to return QUOTE_PRECISION
* init msol config * rm devnet, decimals=9 * update changelog.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.