bigz/update-spot-tvl-invariant-check #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispheaney
reviewed
Jul 19, 2023
programs/drift/src/controller/pnl.rs
Outdated
| @@ -129,7 +129,12 @@ pub fn settle_pnl( | |||
| user_unsettled_pnl, | |||
| now, | |||
| )?; | |||
|
|
|||
| crate::dlog!( | |||
There was a problem hiding this comment.
would be nice to remove if not intentional
| @@ -252,7 +252,7 @@ pub fn update_spot_balances( | |||
| } | |||
| } | |||
|
|
|||
| if let SpotBalanceType::Borrow = update_direction { | |||
| if force_round_up && update_direction == &SpotBalanceType::Borrow { | |||
There was a problem hiding this comment.
should we change the name for force_round_up to better capture when it should be on/off?
There was a problem hiding this comment.
dont we need to change fulfill_with_external_market for spot to use this?
| depositors_amount, | ||
| borrowers_amount | ||
| )?; | ||
| // validate!( |
* sdk: create rpc method to get transactions to avoid some web3.js overhead * sdk: custom parse logs logic
* program: add post only slide for perps * tests * add to ts types * CHANGELOG
* program: add cancelOrdersByIds * CHANGELOG
* sdk: fix liq price issue * incorp getPerpPositionWithLPSettle across sdk/margin calc properly * rename burnLpShares, in getPerpPositionWithLPSettle * CHANGELOG --------- Co-authored-by: 0xbigz <[email protected]> Co-authored-by: Chris Heaney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
add more tests for transfers/withdraw invariants