program: vamm gives maker rebate #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xbigz
reviewed
Nov 27, 2023
| stateAccount.spotFeeStructure.feeTiers[0].makerRebateNumerator; | ||
| makerRebateDenominator = | ||
| stateAccount.spotFeeStructure.feeTiers[0].makerRebateDenominator; | ||
| } |
There was a problem hiding this comment.
todo i guess if the tiers have different maker rebates?
There was a problem hiding this comment.
cant really do cuz we don't have user stats available
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 74.49% 74.65% +0.16%
==========================================
Files 125 125
Lines 29082 29254 +172
==========================================
+ Hits 21664 21839 +175
+ Misses 7418 7415 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.