-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
program: fill_perp checks maintenance margin req if position is reduced #714
Merged
crispheaney
merged 7 commits into
master
from
crispheaney/position-reducing-maker-maint-check
Nov 24, 2023
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a58c17a
program: fill_perp checks maintenance margin req if position is reduced
crispheaney e2796e1
add test for update_maker_fills_map
crispheaney 5f4473a
add another test
crispheaney d3c3fbc
tweak name
crispheaney b13b2dc
add total maker fill check
crispheaney 229ad5a
fix typo
crispheaney 19f3c62
CHANGELOG
crispheaney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1247,3 +1247,22 @@ pub fn estimate_price_from_side(side: &Side, depth: u64) -> DriftResult<Option<u | |
|
||
Ok(price) | ||
} | ||
|
||
pub fn select_margin_type_for_perp_maker( | ||
maker: &User, | ||
based_asset_amount_filled: i64, | ||
market_index: u16, | ||
) -> DriftResult<MarginRequirementType> { | ||
let current_position = maker | ||
.get_perp_position(market_index) | ||
.map_or(0, |p| p.base_asset_amount); | ||
let position_before = current_position.safe_sub(based_asset_amount_filled)?; | ||
|
||
if current_position.signum() == position_before.signum() | ||
&& current_position.abs() < position_before.abs() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good candidate for helper function position_after.was_reduced(position_before) |
||
{ | ||
return Ok(MarginRequirementType::Maintenance); | ||
} | ||
|
||
Ok(MarginRequirementType::Fill) | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is position after fill? maybe good to specify somewhere