Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all projects changed if file effecting all modules changes #105

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

joshafeinberg
Copy link
Member

closes #102

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #105 (c18d77b) into main (1e9066c) will decrease coverage by 0.10%.
The diff coverage is 85.71%.

❗ Current head c18d77b differs from pull request most recent head f5221e1. Consider uploading reports for the commit f5221e1 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #105      +/-   ##
============================================
- Coverage     50.22%   50.11%   -0.11%     
  Complexity       54       54              
============================================
  Files            12       12              
  Lines           450      443       -7     
  Branches         95       91       -4     
============================================
- Hits            226      222       -4     
  Misses          194      194              
+ Partials         30       27       -3     
Impacted Files Coverage Δ
...x/affectedmoduledetector/AffectedModuleDetector.kt 41.47% <85.71%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e9066c...f5221e1. Read the comment docs.

Copy link

@wclausen wclausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change needed to test name, but otherwise lgtm!

@wclausen wclausen merged commit 6b96c3e into main Jan 13, 2022
@joshafeinberg joshafeinberg deleted the jfein/include-all branch January 13, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProjectSubset.CHANGED_PROJECTS should respect pathsAffectingAllModules
2 participants