Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for toggling if uncommitted code should be included #113

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

joshafeinberg
Copy link
Member

The GitClient has support to include uncommitted code and setting a custom top but that functionality was all hard coded. This PR adds the ability to configure those in the AffectedModuleConfiguration

@@ -216,4 +216,47 @@ class AffectedModuleConfigurationTest {
assertThat(config.compareFrom).isEqualTo("PreviousCommit")
}
}

@Test
fun `GIVEN AffectedModuleConfiguration WHEN top THEN is HEAD`() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests!

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #113 (7961016) into main (5d0a8e8) will increase coverage by 0.44%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #113      +/-   ##
============================================
+ Coverage     50.11%   50.55%   +0.44%     
- Complexity       54       59       +5     
============================================
  Files            12       12              
  Lines           443      451       +8     
  Branches         91       91              
============================================
+ Hits            222      228       +6     
- Misses          194      196       +2     
  Partials         27       27              
Impacted Files Coverage Δ
...x/affectedmoduledetector/AffectedModuleDetector.kt 41.34% <60.00%> (-0.14%) ⬇️
...ectedmoduledetector/AffectedModuleConfiguration.kt 100.00% <100.00%> (ø)
...in/com/dropbox/affectedmoduledetector/GitClient.kt 16.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0a8e8...7961016. Read the comment docs.

@changusmc changusmc merged commit 897934e into main Feb 2, 2022
@joshafeinberg joshafeinberg deleted the jfein/fix-flag branch February 2, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants