Upgrade sample app to Kotlin 1.6.10 and ensure it builds on CI #116
Conversation
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 50.55% 50.55%
Complexity 59 59
=========================================
Files 12 12
Lines 451 451
Branches 91 91
=========================================
Hits 228 228
Misses 196 196
Partials 27 27 Continue to review full report at Codecov.
|
| @@ -2,17 +2,18 @@ | |||
| * Copyright (c) 2020, Dropbox, Inc. All rights reserved. | |||
| */ | |||
| plugins { | |||
| kotlin("jvm") version "1.4.10" | |||
| kotlin("jvm") version "1.6.10" | |||
There was a problem hiding this comment.
Can we reuse the constants from Dependencies?
There was a problem hiding this comment.
Doesn't appear so. I think since that file is defined inside the buildSrc project we can't use it in the build.gradle for buildSrc
| run: | | ||
| ./gradlew :affectedmoduledetector:publishToMavenLocal | ||
| cd sample | ||
| ./gradlew build |
There was a problem hiding this comment.
Thanks, we used to have this in Travis, but seems like we lost it.
No description provided.